Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update download_logs url #398

Merged
merged 1 commit into from
Feb 16, 2024
Merged

feat: update download_logs url #398

merged 1 commit into from
Feb 16, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Feb 14, 2024

Related issue

Companion PR Substra/substra-backend#824

Summary

Notes

Fixes FL-1285

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@SdgJlbl SdgJlbl requested a review from a team as a code owner February 14, 2024 15:35
@SdgJlbl SdgJlbl changed the title Feat/download task logs feat: update download_logs url Feb 14, 2024
@SdgJlbl SdgJlbl changed the base branch from main to geat/update-task-status February 14, 2024 15:38
Base automatically changed from geat/update-task-status to main February 15, 2024 16:29
@SdgJlbl SdgJlbl force-pushed the feat/download-task-logs branch from 41527e7 to 3cc055c Compare February 15, 2024 16:51
Copy link

linear bot commented Feb 15, 2024

@SdgJlbl SdgJlbl force-pushed the feat/download-task-logs branch from 3cc055c to b119ed1 Compare February 15, 2024 17:02
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✍️

Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@SdgJlbl SdgJlbl merged commit 8070c93 into main Feb 16, 2024
6 checks passed
@SdgJlbl SdgJlbl deleted the feat/download-task-logs branch February 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants